[Clanlib-devel] PATCH: Fix use of 32 bpp rgba textures with mesa-6.5.2

[Hans de Goede]

Hi all,

ClanLib contains some less then optimal code, which creates a texture in one
format and then does a partial upload (TexSubImage2D()) with another format,
this means that the OpenGL lib will need to convert things internally, as the
texture internally has the format given upon creation.

This less then optimal code also happens to trigger a bug in the (appereantly
not often used) conversion code when using mesa with a (any) ati radeon card.

The attached patch fixes ClanLib to use the same format in both cases.

For much more details on this, see:
https://bugs.freedesktop.org/show_bug.cgi?id=10491

Regards,

Hans

p.s.

I used to not be on the list, but I've subscribed now, I wonder did you guys
ever receive my fully rewritten X-windows fullscreen support ??

[Seth A. Robinson]

Hi Hans,

Thanks for the patch.

Sorry, I've not tested or applied your final rewrite (I'm the one that
tested the intitial one), but after reading about a related problem here:

http://www.rtsoft.com/forums/showthread.php?p=5884#post5884

it looks like I need to get on this ASAP and stop procrastinating with it.

Will apply and check both patches on my linux box asap. If anyone else can
test and let me know if any issues as well that would be great.

Seth A. Robinson
www.rtsoft.com


-----Original Message-----
From: Hans de Goede [mailto:***@hhs.nl]
Sent: Sunday, April 01, 2007 6:11 AM
To: clanlib-***@lists.sourceforge.net
Subject: [Clanlib-devel] PATCH: Fix use of 32 bpp rgba textures
withmesa-6.5.2

Hi all,

ClanLib contains some less then optimal code, which creates a texture in one
format and then does a partial upload (TexSubImage2D()) with another format,
this means that the OpenGL lib will need to convert things internally, as
the
texture internally has the format given upon creation.

This less then optimal code also happens to trigger a bug in the
(appereantly
not often used) conversion code when using mesa with a (any) ati radeon
card.

The attached patch fixes ClanLib to use the same format in both cases.

For much more details on this, see:
https://bugs.freedesktop.org/show_bug.cgi?id=10491

Regards,

Hans

p.s.

I used to not be on the list, but I've subscribed now, I wonder did you guys

ever receive my fully rewritten X-windows fullscreen support ??

[Seth A. Robinson]

Patches committed, thanks. I saw a big performance increase in my game from
your changes, rendering at least 30% faster in linux! (some crappy onboard
nvidia card)

Thanks,

Seth A. Robinson
www.rtsoft.com


-----Original Message-----
From: Hans de Goede [mailto:***@hhs.nl]
Sent: Sunday, April 01, 2007 6:11 AM
To: clanlib-***@lists.sourceforge.net
Subject: [Clanlib-devel] PATCH: Fix use of 32 bpp rgba textures
withmesa-6.5.2

Hi all,

ClanLib contains some less then optimal code, which creates a texture in one
format and then does a partial upload (TexSubImage2D()) with another format,
this means that the OpenGL lib will need to convert things internally, as
the
texture internally has the format given upon creation.

This less then optimal code also happens to trigger a bug in the
(appereantly
not often used) conversion code when using mesa with a (any) ati radeon
card.

The attached patch fixes ClanLib to use the same format in both cases.

For much more details on this, see:
https://bugs.freedesktop.org/show_bug.cgi?id=10491

Regards,

Hans

p.s.

I used to not be on the list, but I've subscribed now, I wonder did you guys

ever receive my fully rewritten X-windows fullscreen support ??

[Hans de Goede]

Post by Seth A. Robinson
Patches committed, thanks. I saw a big performance increase in my game from
your changes, rendering at least 30% faster in linux! (some crappy onboard
nvidia card)

Glad you like it, it took my almost a day of debugging mesa to find out that
this sub optimal code in CalnLib was triggering the bug and it would be easier
to just fix ClanLib to workaround the bug.

Regards,

Hans